feat!: HDRN implementation & associated features with breaking changes to groups & perms by JackScanlon · Pull Request #1859 · SwanseaUniversityMedical/concept-library

JackScanlon · 2025-06-27T15:19:21Z

Breaking changes

Groups replaced by Organisations
Permissions changes to account for Organisations, incl. deprecation of visibility behaviour

Overview

See related PR:

Feat/hdrn #1790

See related tasks:

…et-implementation

…ingset-implementation

Co-authored-by: ieuans <ieuanscanlon@hotmail.co.uk> Co-authored-by: JackScanlon <jackascanlon@hotmail.co.uk> Co-authored-by: Arthur zinnurov <zinnurov_2012@mail.ru> Co-authored-by: roshantoby <roshantoby@gmail.com>

github-actions · 2025-06-27T15:24:52Z

✒️ PR Title Commitlint - ✔️ Lint success!

github-actions · 2025-06-27T15:29:35Z

File	Coverage
All files	`36%`	✅
manage.py	`0%`	❌
clinicalcode/admin.py	`63%`	✅
clinicalcode/apps.py	`84%`	✅
clinicalcode/clinicalcode.py	`0%`	❌
clinicalcode/tasks.py	`35%`	✅
clinicalcode/test_permissions.py	`85%`	✅
clinicalcode/api/serializers.py	`0%`	❌
clinicalcode/api/urls.py	`81%`	✅
clinicalcode/api/views/Collection.py	`43%`	✅
clinicalcode/api/views/Concept.py	`10%`	❌
clinicalcode/api/views/DataSource.py	`28%`	✅
clinicalcode/api/views/GenericEntity.py	`22%`	❌
clinicalcode/api/views/Healthcheck.py	`48%`	✅
clinicalcode/api/views/Ontology.py	`23%`	❌
clinicalcode/api/views/Tag.py	`43%`	✅
clinicalcode/api/views/Template.py	`75%`	✅
clinicalcode/api/views/View.py	`22%`	❌
clinicalcode/audit/request_signals.py	`0%`	❌
clinicalcode/context_processors/app.py	`0%`	❌
clinicalcode/entity_utils/api_utils.py	`38%`	✅
clinicalcode/entity_utils/concept_utils.py	`8%`	❌
clinicalcode/entity_utils/constants.py	`97%`	✅
clinicalcode/entity_utils/create_utils.py	`21%`	❌
clinicalcode/entity_utils/data_utils.py	`0%`	❌
clinicalcode/entity_utils/email_utils.py	`18%`	❌
clinicalcode/entity_utils/entity_db_utils.py	`10%`	❌
clinicalcode/entity_utils/filter_utils.py	`22%`	❌
clinicalcode/entity_utils/gen_utils.py	`14%`	❌
clinicalcode/entity_utils/model_utils.py	`27%`	✅
clinicalcode/entity_utils/permission_utils.py	`29%`	✅
clinicalcode/entity_utils/publish_utils.py	`13%`	❌
clinicalcode/entity_utils/sanitise_utils.py	`29%`	✅
clinicalcode/entity_utils/search_utils.py	`23%`	❌
clinicalcode/entity_utils/stats_utils.py	`10%`	❌
clinicalcode/entity_utils/template_utils.py	`36%`	✅
clinicalcode/entity_utils/markdown/strikethrough.py	`0%`	❌
clinicalcode/entity_utils/markdown/utils.py	`19%`	❌
clinicalcode/forms/ArchiveForm.py	`42%`	✅
clinicalcode/forms/ContactUsForm.py	`62%`	✅
clinicalcode/forms/EntityClassForm.py	`64%`	✅
clinicalcode/forms/OrganisationForms.py	`64%`	✅
clinicalcode/forms/TemplateForm.py	`43%`	✅
clinicalcode/generators/graphs/constants.py	`0%`	❌
clinicalcode/generators/graphs/generator.py	`0%`	❌
clinicalcode/generators/graphs/utils.py	`0%`	❌
clinicalcode/management/commands/clear_sessions.py	`0%`	❌
clinicalcode/management/commands/constants.py	`0%`	❌
clinicalcode/management/commands/dag_tasks.py	`0%`	❌
clinicalcode/management/commands/dftm_migrate.py	`0%`	❌
clinicalcode/management/commands/pheno_labels.py	`0%`	❌
clinicalcode/middleware/brands.py	`64%`	✅
clinicalcode/middleware/compression.py	`84%`	✅
clinicalcode/middleware/exceptions.py	`61%`	✅
clinicalcode/middleware/sessions.py	`87%`	✅
clinicalcode/models/Brand.py	`41%`	✅
clinicalcode/models/Code.py	`87%`	✅
clinicalcode/models/CodeList.py	`90%`	✅
clinicalcode/models/CodingSystem.py	`83%`	✅
clinicalcode/models/CodingSystemFilter.py	`95%`	✅
clinicalcode/models/Component.py	`97%`	✅
clinicalcode/models/Concept.py	`85%`	✅
clinicalcode/models/ConceptCodeAttribute.py	`94%`	✅
clinicalcode/models/ConceptReviewStatus.py	`94%`	✅
clinicalcode/models/DataSource.py	`94%`	✅
clinicalcode/models/EntityClass.py	`94%`	✅
clinicalcode/models/GenericEntity.py	`83%`	✅
clinicalcode/models/HDRNDataAsset.py	`48%`	✅
clinicalcode/models/HDRNDataCategory.py	`37%`	✅
clinicalcode/models/HDRNJurisdiction.py	`35%`	✅
clinicalcode/models/HDRNSite.py	`35%`	✅
clinicalcode/models/OntologyTag.py	`22%`	❌
clinicalcode/models/Operator.py	`80%`	✅
clinicalcode/models/Organisation.py	`51%`	✅
clinicalcode/models/Phenotype.py	`80%`	✅
clinicalcode/models/PhenotypeWorkingset.py	`74%`	✅
clinicalcode/models/PublishedGenericEntity.py	`64%`	✅
clinicalcode/models/Statistics.py	`94%`	✅
clinicalcode/models/Tag.py	`51%`	✅
clinicalcode/models/Template.py	`59%`	✅
clinicalcode/models/WorkingSet.py	`82%`	✅
clinicalcode/storage/files_manifest.py	`0%`	❌
clinicalcode/templatetags/breadcrumbs.py	`18%`	❌
clinicalcode/templatetags/cards_dropdown_render.py	`45%`	✅
clinicalcode/templatetags/cl_extras.py	`57%`	✅
clinicalcode/templatetags/entity_publish_renderer.py	`14%`	❌
clinicalcode/templatetags/entity_renderer.py	`33%`	✅
clinicalcode/templatetags/svg.py	`50%`	✅
clinicalcode/tests/conftest.py	`83%`	✅
clinicalcode/tests/functional_tests/test_collection_components.py	`84%`	✅
clinicalcode/tests/functional_tests/test_detail_components.py	`48%`	✅
clinicalcode/tests/functional_tests/test_moderation_components.py	`90%`	✅
clinicalcode/tests/functional_tests/test_search_filters.py	`81%`	✅
clinicalcode/tests/functional_tests/test_template_versions.py	`59%`	✅
clinicalcode/tests/unit_tests/test_publishing.py	`19%`	❌
clinicalcode/views/Account.py	`45%`	✅
clinicalcode/views/Admin.py	`19%`	❌
clinicalcode/views/Decline.py	`43%`	✅
clinicalcode/views/DocumentationViewer.py	`50%`	✅
clinicalcode/views/GenericEntity.py	`25%`	✅
clinicalcode/views/Moderation.py	`55%`	✅
clinicalcode/views/Organisation.py	`23%`	❌
clinicalcode/views/Profile.py	`47%`	✅
clinicalcode/views/Publish.py	`20%`	❌
clinicalcode/views/View.py	`24%`	❌
clinicalcode/views/adminTemp.py	`12%`	❌
clinicalcode/views/site.py	`27%`	✅
clinicalcode/views/dashboard/BrandAdmin.py	`29%`	✅
clinicalcode/views/dashboard/targets/BaseTarget.py	`20%`	❌
clinicalcode/views/dashboard/targets/BrandTarget.py	`36%`	✅
clinicalcode/views/dashboard/targets/HDRNCategoryTarget.py	`50%`	✅
clinicalcode/views/dashboard/targets/HDRNDataAssetTarget.py	`31%`	✅
clinicalcode/views/dashboard/targets/HDRNJurisdictionTarget.py	`63%`	✅
clinicalcode/views/dashboard/targets/HDRNSiteTarget.py	`63%`	✅
clinicalcode/views/dashboard/targets/OrganisationTarget.py	`23%`	❌
clinicalcode/views/dashboard/targets/PeopleTarget.py	`0%`	❌
clinicalcode/views/dashboard/targets/TagTarget.py	`44%`	✅
clinicalcode/views/dashboard/targets/TemplateTarget.py	`29%`	✅
clinicalcode/views/dashboard/targets/UserTarget.py	`25%`	✅
clinicalcode/views/tests/test_views.py	`0%`	❌
cll/celery.py	`92%`	✅
cll/read_only_test_settings.py	`0%`	❌
cll/settings.py	`87%`	✅
cll/tasks.py	`0%`	❌
cll/test_settings.py	`95%`	✅
cll/urls.py	`0%`	❌
cll/urls_brand.py	`79%`	✅
cll/wsgi.py	`0%`	❌

Minimum allowed coverage is 25%

Generated by 🐒 cobertura-action against dd036f9

ZinnurovArtur added 30 commits March 4, 2024 14:03

add attibute button html

a2a61ec

some logic in concept creator

8a9657d

adding the attribute component

96d2d69

initialize the component inside creator

2542464

adding to the concept create page

b6dd169

adding the input values

a3b8be7

deleted some spaces

706ed7d

Merge remote-tracking branch 'origin/Development' into artur-workings…

db06dbe

…et-implementation

adding icon to the attribute button

788ef05

using basic style

b92513d

some experiments

1c44ff7

some data is returning

d04d841

adding components for testing

37fc043

Merge remote-tracking branch 'origin/Development' into artur-workings…

39f8710

…et-implementation

deleted title

efa421e

adding different dropdown

662dc90

attribute type for input

9382dc6

adding the test modal with attributes

40d6d18

adding test mockup modal

0c1f92c

call the import setting for now

ecb2ef5

adding the setting page for attributs

04b7af5

call modal attribute for now

f9d183b

deleting unused

0dbc4cd

delete unused code

58e2bf3

deletion some other code

44bdd8d

deleted unused

b19375e

table test addition

c41a886

adding package to html

4ce9873

Merge remote-tracking branch 'origin/Development' into artur-workings…

fc772ca

…et-implementation

using the different package installer

dd30ab3

ZinnurovArtur and others added 18 commits November 6, 2024 15:56

adding checks on the backend

a2357fe

removed console log

8f114f9

adding another regex check

5e8c4ac

removing string validation on the backend

c41f15c

fixing showing the concept attribute in the detail page

4d8474d

removing unpackage for js

cb99cbe

adding grid js scss

97e91d7

adding grid.js to the create scss

628423d

adjusting the float values

5c631d3

scss changes

0dcae45

Merge remote-tracking branch 'origin/AZ/dev-upstream' into artur-work…

d2670f3

…ingset-implementation

removed some comments

e665981

renamed to accordion and changed id

17ee8ab

renamded to accordion

813009c

Updated workingset (#1775)

b8ac044

Adding workingset from upstream (#1778)

11f6c63

fix: fixing the js file for attributes tool

09db2a2

feat: Feat/hdrn (#1790)

aff8c42

Co-authored-by: ieuans <ieuanscanlon@hotmail.co.uk> Co-authored-by: JackScanlon <jackascanlon@hotmail.co.uk> Co-authored-by: Arthur zinnurov <zinnurov_2012@mail.ru> Co-authored-by: roshantoby <roshantoby@gmail.com>

JackScanlon requested review from a team, Hannah-Davies and ieuans as code owners June 27, 2025 15:19

Merge branch 'master' into Development

dd036f9

JackScanlon changed the title ~~feat!(app): HDRN implementation & associated features with breaking changes to groups & perms~~ feat(app)!: HDRN implementation & associated features with breaking changes to groups & perms Jun 27, 2025

JackScanlon changed the title ~~feat(app)!: HDRN implementation & associated features with breaking changes to groups & perms~~ feat!: HDRN implementation & associated features with breaking changes to groups & perms Jun 27, 2025

ieuans approved these changes Jul 1, 2025

View reviewed changes

ieuans merged commit 6816a66 into master Jul 1, 2025
4 of 7 checks passed

ieuans deleted the Development branch July 1, 2025 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: HDRN implementation & associated features with breaking changes to groups & perms#1859

feat!: HDRN implementation & associated features with breaking changes to groups & perms#1859
ieuans merged 118 commits intomasterfrom
Development

JackScanlon commented Jun 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

JackScanlon commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking changes

Overview

Uh oh!

github-actions bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✒️ PR Title Commitlint - ✔️ Lint success!

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JackScanlon commented Jun 27, 2025 •

edited

Loading

github-actions bot commented Jun 27, 2025 •

edited

Loading